[coreboot] [patch] RE: Fam10 breakage

Patrick Georgi patrick at georgi-clan.de
Mon Mar 1 17:48:04 CET 2010

Am 01.03.2010 17:23, schrieb Myles Watson:
>> However, this does not fix the bug in our stack size calculation.
>> I'm not quite sure if the patch does the right thing, but it should be
>> close.
> I don't think we need to make the SMP check.  Can't we just put in an assert
> that checks for RAMBASE < 0xa0000 and eheap > 0xa0000?  One large stack
> could just as easily break this.
True. Attached patch might do this (only moderately tested)

I think the only reason why we can't get rid of RAMBASE <1M completely
is a couple of boards (Via based iirc) that have their own vgabios.c
that breaks with RAMBASE >1M

The other RAMBASE we sometimes use (mostly on AMD boards) is RAMBASE==2M
- what was the rationale for that again?

With those two gone, we could hide RAMBASE somewhere in Kconfig or
eliminate it completely.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 20100301-2-remove-special-stack-size-retry
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20100301/01c8ae97/attachment.ksh>

More information about the coreboot mailing list