[coreboot] [PATCH] Factor out common CAR asm snippets

Uwe Hermann uwe at hermann-uwe.de
Sat Oct 2 00:07:56 CEST 2010

On Fri, Oct 01, 2010 at 03:46:31PM -0600, Myles Watson wrote:
> This was surprising:
> + * Copyright (C) 2000,2007 Ronald G. Minnich <rminnich at gmail.com>
> + * Copyright (C) 2007-2008 coresystems GmbH

Yeah, I copied most of the stuff from model_6ex or something like that,
hence the (C) lines, but it's all generic simple stuff, maybe I should
have made it (C) Uwe Hermann <uwe at hermann-uwe.de> ?

> The macros are well named.  I'd prefer including comments only for ones that
> need an explanation.

I'll extend the comments a bit more later, wanted to leave that for
another patch.

http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org

More information about the coreboot mailing list