[coreboot] [PATCH] Factor out common CAR asm snippets

Myles Watson mylesgw at gmail.com
Fri Oct 1 23:46:31 CEST 2010


This was surprising:

+ * Copyright (C) 2000,2007 Ronald G. Minnich <rminnich at gmail.com>
+ * Copyright (C) 2007-2008 coresystems GmbH

The macros are well named.  I'd prefer including comments only for ones that
need an explanation.

+/* Disable cache. */
+#define disable_cache() \
+	movl	%cr0, %eax; \
+	orl	$(1 << 30), %eax; \
+	movl	%eax, %cr0
+

Thanks,
Myles





More information about the coreboot mailing list