[coreboot] [PATCH] Remove various .c #includes from Intel 440BX/82371EB boards
vidwer at gmail.com
Sat Oct 9 18:41:39 CEST 2010
2010/10/9 Uwe Hermann <uwe at hermann-uwe.de>
> On Fri, Oct 08, 2010 at 02:41:40AM -0400, Corey Osgood wrote:
> > I think I've found the problem, include/console/console.h:
> > 62 #ifndef __ROMCC__
> > 63 void console_init(void);
> > 64 void post_code(u8 value);
> > 65 void __attribute__ ((noreturn)) die(const char *msg);
> > Maybe move that definition a few lines up, and see what happens? Or
> So far I couldn't find a combination which works, but it's not needed at
> the moment, I can dodge the problem by removing the die() calls
> alltogether, that was on my TODO list anyways. Those checks in the code
> are not really useful, the PCI device is always there, and we don't do
> such checks elsewhere in the code either.
> Updated patch attached, now survives abuild.
Note that compilation breaks when using CONFIG_DEBUG_RAM_SETUP=y.
Apart from that:
Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
Acking the second patch (v4_remove_c_includes_i82371eb_2.patch):
Acked-by: Idwer Vollering <vidwer at gmail.com>
> > else converting the QEMU target to CAR seems like the other option.
> That won't work as far as I've heard (QEMU limitations).
> http://hermann-uwe.de | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org
> coreboot mailing list: coreboot at coreboot.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the coreboot