[coreboot-gerrit] New patch to review for coreboot: fa8737d sitemp_g1p1: fixed serial output for simo-board

Dennis Wassenberg (dennis.wassenberg@secunet.com) gerrit at coreboot.org
Tue Oct 14 17:42:04 CEST 2014


Dennis Wassenberg (dennis.wassenberg at secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7060

-gerrit

commit fa8737db2efd999c684a7a1d297386c25b55a31d
Author: Dennis Wassenberg <dennis.wassenberg at secunet.com>
Date:   Tue Oct 14 17:29:36 2014 +0200

    sitemp_g1p1: fixed serial output for simo-board
    
    The Simo-board with console output at UART port 1 (COM2) will not produce
    any output if CONFIG_UART_FOR_CONSOLE=1 is set correctly.
    Commit f29200240e428761827ab8d179fa23068bfa9d59 will only and always
    activate UART port 0 unregarded to CONFIG_UART_FOR_CONSOLE value.
    Now the UART port which was selected by CONFIG_UART_FOR_CONSOLE
    will be enabled and used for console output
    
    Change-Id: Ibbd2b5115b1ed4763962ba32fc9c19431a906c78
    Signed-off-by: Dennis Wassenberg <dennis.wassenberg at secunet.com>
---
 src/mainboard/siemens/sitemp_g1p1/romstage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/siemens/sitemp_g1p1/romstage.c b/src/mainboard/siemens/sitemp_g1p1/romstage.c
index 3332999..4beb8c9 100644
--- a/src/mainboard/siemens/sitemp_g1p1/romstage.c
+++ b/src/mainboard/siemens/sitemp_g1p1/romstage.c
@@ -46,7 +46,7 @@
 #include "southbridge/amd/sb600/early_setup.c"
 #include "northbridge/amd/amdk8/debug.c" /* After sb600_early_setup.c! */
 
-#define SERIAL_DEV PNP_DEV(0x2e, IT8712F_SP1)
+#define SERIAL_DEV PNP_DEV(0x2e, CONFIG_UART_FOR_CONSOLE == 1 ? IT8712F_SP2 : IT8712F_SP1)
 #define GPIO_DEV PNP_DEV(0x2e, IT8712F_GPIO)
 
 /* CAN'T BE REMOVED! crt0.S will use it. I don't know WHY!*/



More information about the coreboot-gerrit mailing list