[coreboot-gerrit] Patch merged into coreboot/master: 375e6ce intel/fsp_baytrail: Clear the GNVS area prior to filling

gerrit at coreboot.org gerrit at coreboot.org
Tue Oct 14 18:58:50 CEST 2014


the following patch was just integrated into master:
commit 375e6ce4aeee449c34a6d3efb6374c5684f7b32f
Author: Scott Radcliffe <sradcliffe at microind.com>
Date:   Fri Oct 10 16:26:05 2014 -0400

    intel/fsp_baytrail: Clear the GNVS area prior to filling
    
    Zero out the GNVS area so that uninitialized portions are defined.
    
    Tests using Microsoft Windows (XP/7/8) gave a bluescreen bugcheck: A5
    (ACPI_BIOS_ERROR) with the first parameter (0x00001000)
    (ACPI_BIOS_USING_OS_MEMORY). Some ACPI enumerated devices use the
    GNVS area to define whether they're enabled and their MMIO regions.
    On my custom baytrail-based board and build, these devices were
    disabled but GNVS had uninitialized data indicating the devices
    were enabled with improper MMIO regions.
    
    Should investigate further to see where the GNVS device values are
    set if enabled and make sure they're set to valid values even when
    the devices are disabled via the mainboard/devicetree.cb.
    
    Change-Id: I2b575c65bfaab58ae6206ac6f457c259c27a7d97
    Signed-off-by: Scott Radcliffe <sradcliffe at microind.com>
    Reviewed-on: http://review.coreboot.org/7040
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>


See http://review.coreboot.org/7040 for details.

-gerrit



More information about the coreboot-gerrit mailing list