[coreboot-gerrit] New patch to review for coreboot: bf75e23 rambi: always show dev/rec screens on eDP connected panel

Marc Jones (marc.jones@se-eng.com) gerrit at coreboot.org
Tue Oct 28 00:05:56 CET 2014


Marc Jones (marc.jones at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/7216

-gerrit

commit bf75e231a1f3ad72750d04045fdc5f1e5b9c11f8
Author: Kein Yuan <kein.yuan at intel.com>
Date:   Tue Apr 1 10:13:38 2014 -0700

    rambi: always show dev/rec screens on eDP connected panel
    
    bit: 7    6     5     4     3    2    1   0
         LFP2 EFP2  EFP3  CRT2  LFP  EFP  TV  CRT
    so int 15 0x5f35 need to return 0x8(LFP/eDP) instead of 0x2(TV).
    
    BUG=chrome-os-partner:26365
    BUG=chrome-os-partner:27505
    BRANCH=rambi
    TEST=Booted with and without HDMI connected monitor. DEV screen
         always showed on eDP panel on Rambi.
    
    Change-Id: I8f876e78383424f517689eb25e9229a27739957b
    Original-Change-Id: I77edbeb3c86549f90302b4296b5a2f50313ca675
    Signed-off-by: Kein Yuan <kein.yuan at intle.com>
    Reviewed-on: https://chromium-review.googlesource.com/193303
    Commit-Queue: Shawn Nematbakhsh <shawnn at chromium.org>
    Tested-by: Shawn Nematbakhsh <shawnn at chromium.org>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    (cherry picked from commit dd375462147f182331f336ba826108e58b4e0a47)
    Signed-off-by: Marc Jones <marc.jones at se-eng.com>
---
 src/mainboard/google/rambi/mainboard.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/google/rambi/mainboard.c b/src/mainboard/google/rambi/mainboard.c
index 19579fb..cd3fc48 100644
--- a/src/mainboard/google/rambi/mainboard.c
+++ b/src/mainboard/google/rambi/mainboard.c
@@ -66,16 +66,16 @@ static int int15_handler(void)
 		/*
 		 * Boot Display Device Hook:
 		 *  bit 0 = CRT
-		 *  bit 1 = TV (eDP) *
-		 *  bit 2 = EFP
-		 *  bit 3 = LFP
+		 *  bit 1 = TV
+		 *  bit 2 = EFP (HDMI)
+		 *  bit 3 = LFP (eDP)*
 		 *  bit 4 = CRT2
-		 *  bit 5 = TV2 (eDP)
+		 *  bit 5 = TV2
 		 *  bit 6 = EFP2
 		 *  bit 7 = LFP2
 		 */
 		X86_AX = 0x005f;
-		X86_CX = 0x0002;
+		X86_CX = 0x0008;
 		res = 1;
 		break;
 	case 0x5f51:



More information about the coreboot-gerrit mailing list