[coreboot-gerrit] New patch to review for coreboot: 4a0e421 various AMD boards: fix buffer overflow

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Mon Sep 29 20:25:19 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6991

-gerrit

commit 4a0e421ea8a5ca5e71524392448e4774f15cb9ee
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Sep 29 20:23:29 2014 +0200

    various AMD boards: fix buffer overflow
    
    "AMD\t " isn't 8 characters long.
    
    Change-Id: I47b2a39d7dca0201b7ee5dfd1f77e0714411257c
    Found-by: Coverity Scan
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/mainboard/gizmosphere/gizmo/mptable.c      | 2 +-
 src/mainboard/lippert/frontrunner-af/mptable.c | 2 +-
 src/mainboard/lippert/toucan-af/mptable.c      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/mainboard/gizmosphere/gizmo/mptable.c b/src/mainboard/gizmosphere/gizmo/mptable.c
index ed52722..b98598a 100755
--- a/src/mainboard/gizmosphere/gizmo/mptable.c
+++ b/src/mainboard/gizmosphere/gizmo/mptable.c
@@ -56,7 +56,7 @@ static void *smp_write_config_table(void *v)
 	mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
 
 	mptable_init(mc, LOCAL_APIC_ADDR);
-	memcpy(mc->mpc_oem, "AMD	 ", 8);
+	memcpy(mc->mpc_oem, "AMD     ", 8);
 
 	smp_write_processors(mc);
 
diff --git a/src/mainboard/lippert/frontrunner-af/mptable.c b/src/mainboard/lippert/frontrunner-af/mptable.c
index de573b8..078601e 100644
--- a/src/mainboard/lippert/frontrunner-af/mptable.c
+++ b/src/mainboard/lippert/frontrunner-af/mptable.c
@@ -54,7 +54,7 @@ static void *smp_write_config_table(void *v)
 	mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
 
 	mptable_init(mc, LOCAL_APIC_ADDR);
-	memcpy(mc->mpc_oem, "AMD	 ", 8);
+	memcpy(mc->mpc_oem, "AMD     ", 8);
 
 	smp_write_processors(mc);
 
diff --git a/src/mainboard/lippert/toucan-af/mptable.c b/src/mainboard/lippert/toucan-af/mptable.c
index de573b8..078601e 100644
--- a/src/mainboard/lippert/toucan-af/mptable.c
+++ b/src/mainboard/lippert/toucan-af/mptable.c
@@ -54,7 +54,7 @@ static void *smp_write_config_table(void *v)
 	mc = (void *)(((char *)v) + SMP_FLOATING_TABLE_LEN);
 
 	mptable_init(mc, LOCAL_APIC_ADDR);
-	memcpy(mc->mpc_oem, "AMD	 ", 8);
+	memcpy(mc->mpc_oem, "AMD     ", 8);
 
 	smp_write_processors(mc);
 



More information about the coreboot-gerrit mailing list