[coreboot-gerrit] New patch to review for coreboot: cad6c37 intel/i945: Another magic number

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Mon Sep 29 20:43:49 CEST 2014


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6992

-gerrit

commit cad6c37f7fb4732ea2700b7505f407c1d1c307d1
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Mon Sep 29 20:42:33 2014 +0200

    intel/i945: Another magic number
    
    Replace it with the existing #define
    
    Change-Id: I6e67ed1a455cd4f9eeed1865b9ef981e7ef0a874
    Found-by: Idwer Vollering
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/northbridge/intel/i945/early_init.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c
index a134683..24054bd 100644
--- a/src/northbridge/intel/i945/early_init.c
+++ b/src/northbridge/intel/i945/early_init.c
@@ -757,7 +757,7 @@ static void i945_setup_pci_express_x16(void)
 		/* Set voltage specific parameters */
 		reg32 = pci_read_config32(PCI_DEV(0, 0x01, 0), 0xe80);
 		reg32 &= (0xf << 4);	/* Default case 1.05V */
-		if ((MCHBAR32(0xe08) & (1 << 20)) == 0) {	/* 1.50V */
+		if ((MCHBAR32(DFT_STRAP1) & (1 << 20)) == 0) {	/* 1.50V */
 			reg32 |= (7 << 4);
 		}
 		pci_write_config32(PCI_DEV(0, 0x01, 0), 0xe80, reg32);



More information about the coreboot-gerrit mailing list