[coreboot-gerrit] New patch to review for coreboot: skylake: fix invalid GNVS base address

[Aaron Durbin (adurbin@chromium.org)]

Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11185

-gerrit

commit cec20ffb42baf4963b74144a2aec5035a6e9ba9c
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Aug 4 15:33:23 2015 -0500

    skylake: fix invalid GNVS base address
    
    Leaving a sentinel 0xC0DEBABE and fixing it up is
    is the old way of setting the correct base address
    for GNVS. One just needs to reference NVSA which is
    already filled in by the skylake ACPI code.
    
    BUG=chrome-os-partner:43611
    BUG=chrome-os-partner:43522
    BRANCH=None
    TEST=Built and booted glados. /sys/firmware/log shows
         up as well as ramoops using the correct address.
    
    Original-Change-Id: I1d4979b1bb65faa76316a4ec4c551a7b9b9eed32
    Original-Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/290338
    Original-Reviewed-by: Duncan Laurie <dlaurie at chromium.org>
    
    Change-Id: I25efea73a383215f9365ce91230f79516b0201a6
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/skylake/acpi/globalnvs.asl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/skylake/acpi/globalnvs.asl b/src/soc/intel/skylake/acpi/globalnvs.asl
index 3df40cd..5d07be7 100644
--- a/src/soc/intel/skylake/acpi/globalnvs.asl
+++ b/src/soc/intel/skylake/acpi/globalnvs.asl
@@ -30,7 +30,8 @@ Name (\PICM, 0)		// IOAPIC/8259
  * we have to fix it up in coreboot's ACPI creation phase.
  */
 
-OperationRegion (GNVS, SystemMemory, 0xC0DEBABE, 0x2000)
+External(NVSA)
+OperationRegion (GNVS, SystemMemory, NVSA, 0x2000)
 Field (GNVS, ByteAcc, NoLock, Preserve)
 {
 	/* Miscellaneous */