[coreboot-gerrit] Patch merged into coreboot/master: Fix Kconfig: ALWAYS_LOAD_OPROM has unmet dependency VGA_ROM_RUN

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 18 00:55:52 CEST 2015


the following patch was just integrated into master:
commit b95fc308af04d06a384cac2972a23dc5e6dbefaf
Author: Martin Roth <martinroth at google.com>
Date:   Mon Aug 17 11:29:01 2015 -0600

    Fix Kconfig: ALWAYS_LOAD_OPROM has unmet dependency VGA_ROM_RUN
    
    Broadwell and Skylake chipsets, along with a few mainboards were
    selecting ALWAYS_LOAD_OPROM without making sure that the dependency
    for that symbol was met as well.
    
    Looking at the dependencies for VGA_RUN_ROM, we see:
    PCI && !PAYLOAD_SEABIOS && !MAINBOARD_DO_NATIVE_VGA_INIT
    
    Since ARCH_X86 selects PCI, that's always met here.
    Since Broadwell and Skylake don't have native VGA init yet, that's
    not needed.
    
    - Make sure that VGA_RUN_ROM is selected as well.
    - Add dependency on !PAYLOAD_SEABIOS for both ALWAYS_LOAD_OPROM and
    VGA_RUN_ROM symbols where they're selected.
    
    Fixes Kconfig warning for these boards and chipsets:
    warning: (BOARD_SPECIFIC_OPTIONS && BOARD_SPECIFIC_OPTIONS &&
    BOARD_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS && CPU_SPECIFIC_OPTIONS)
    selects ALWAYS_LOAD_OPROM which has unmet direct dependencies
    (VGA_ROM_RUN)
    
    Change-Id: I787a87e9467e1fc7afe8b04864b2a89b54824b9f
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: http://review.coreboot.org/11246
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See http://review.coreboot.org/11246 for details.

-gerrit



More information about the coreboot-gerrit mailing list