[coreboot-gerrit] New patch to review for coreboot: intel raminit: add sanity check
Patrick Rudolph (siro@das-labor.org)
gerrit at coreboot.org
Tue Aug 18 07:54:52 CEST 2015
Patrick Rudolph (siro at das-labor.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11247
-gerrit
commit 2a3cf281bbd868fac3411ee6b143f713d0ffb3c9
Author: Patrick Rudolph <siro at das-labor.org>
Date: Sun Aug 16 17:06:30 2015 +0200
intel raminit: add sanity check
Make sure edge write test results are sane.
Most likely the following test is going to fail on the same
rank anyway.
Change-Id: Ifa601406e6c74ceb8d70063be5ce1bf6bc512c18
Signed-off-by: Patrick Rudolph <siro at das-labor.org>
---
3rdparty/blobs | 2 +-
src/northbridge/intel/sandybridge/raminit_native.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/3rdparty/blobs b/3rdparty/blobs
index b4ade40..34b0926 160000
--- a/3rdparty/blobs
+++ b/3rdparty/blobs
@@ -1 +1 @@
-Subproject commit b4ade4096486fd1abcde468de8719e45a721aee7
+Subproject commit 34b09265063c19ea5d61bd5a2f057b47b5aa2232
diff --git a/src/northbridge/intel/sandybridge/raminit_native.c b/src/northbridge/intel/sandybridge/raminit_native.c
index 9df102a..286493b 100644
--- a/src/northbridge/intel/sandybridge/raminit_native.c
+++ b/src/northbridge/intel/sandybridge/raminit_native.c
@@ -3129,6 +3129,8 @@ static void discover_edges_write_real(ramctr_timing * ctrl, int channel,
max(rn.start + ctrl->edge_offset[i], lower[lane]);
upper[lane] =
min(rn.end - ctrl->edge_offset[i], upper[lane]);
+ if (rn.all || lower[lane] > upper[lane])
+ die("edge write discovery failed");
edges[lane] = (lower[lane] + upper[lane]) / 2;
}
More information about the coreboot-gerrit
mailing list