[coreboot-gerrit] New patch to review for coreboot: Remove obsolete EARLY_CONSOLE usage
Martin Roth (gaumless@gmail.com)
gerrit at coreboot.org
Sun Jun 21 01:16:04 CEST 2015
Martin Roth (gaumless at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10615
-gerrit
commit 46504a07363c9e05bcfa658cc7bac22bcff86650
Author: Martin Roth <gaumless at gmail.com>
Date: Sat Jun 20 16:45:30 2015 -0600
Remove obsolete EARLY_CONSOLE usage
The EARLY_CONSOLE Kconfig symbol was removed in
commit 48713a1b - console: Drop EARLY_CONSOLE option
Because the symbol was missing from Kconfig, these platforms had
the early console always disabled instead of the intended always
enabled.
Change-Id: Idc60ffb2bac2b180f4fdd0adf5c411e1f692a846
Signed-off-by: Martin Roth <gaumless at gmail.com>
---
src/arch/arm64/Makefile.inc | 2 +-
src/arch/mips/Makefile.inc | 2 +-
src/mainboard/emulation/qemu-armv7/Kconfig | 1 -
src/soc/broadcom/cygnus/Kconfig | 1 -
src/soc/marvell/bg4cd/Kconfig | 1 -
src/soc/nvidia/tegra132/Kconfig | 1 -
6 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/src/arch/arm64/Makefile.inc b/src/arch/arm64/Makefile.inc
index 13e8415..c63cb4b 100644
--- a/src/arch/arm64/Makefile.inc
+++ b/src/arch/arm64/Makefile.inc
@@ -88,7 +88,7 @@ $(objcbfs)/verstage.debug: $(objgenerated)/libverstage.a $$(verstage-objs)
@printf " LINK $(subst $(obj)/,,$(@))\n"
$(LD_verstage) --gc-sections -static -o $@ -L$(obj) --whole-archive --start-group $(objgenerated)/libverstage.a $$(verstage-objs) --end-group -T $(obj)/mainboard/$(MAINBOARDDIR)/memlayout.verstage.ld
-verstage-$(CONFIG_EARLY_CONSOLE) += early_console.c
+verstage-y += early_console.c
verstage-y += boot.c
verstage-y += div0.c
verstage-y += eabi_compat.c
diff --git a/src/arch/mips/Makefile.inc b/src/arch/mips/Makefile.inc
index cff0151..ccbe740 100644
--- a/src/arch/mips/Makefile.inc
+++ b/src/arch/mips/Makefile.inc
@@ -61,7 +61,7 @@ endif # CONFIG_ARCH_BOOTBLOCK_MIPS
ifeq ($(CONFIG_ARCH_ROMSTAGE_MIPS),y)
romstage-y += boot.c
-romstage-$(CONFIG_EARLY_CONSOLE) += early_console.c
+romstage-y += early_console.c
romstage-y += cache.c
romstage-y += mmu.c
romstage-y += stages.c
diff --git a/src/mainboard/emulation/qemu-armv7/Kconfig b/src/mainboard/emulation/qemu-armv7/Kconfig
index 58ddd4e..c6199ea 100644
--- a/src/mainboard/emulation/qemu-armv7/Kconfig
+++ b/src/mainboard/emulation/qemu-armv7/Kconfig
@@ -26,7 +26,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
select CPU_ARMLTD_CORTEX_A9
select DRIVERS_UART_PL011
select BOOTBLOCK_CONSOLE
- select EARLY_CONSOLE
select CONSOLE_SERIAL
select ARM_BOOTBLOCK_ARMV7
select ARM_ROMSTAGE_ARMV7
diff --git a/src/soc/broadcom/cygnus/Kconfig b/src/soc/broadcom/cygnus/Kconfig
index 7c17bd4..e6da57c 100644
--- a/src/soc/broadcom/cygnus/Kconfig
+++ b/src/soc/broadcom/cygnus/Kconfig
@@ -25,7 +25,6 @@ config SOC_BROADCOM_CYGNUS
select ARCH_ROMSTAGE_ARMV7
select ARCH_VERSTAGE_ARMV7
select BOOTBLOCK_CONSOLE
- select EARLY_CONSOLE
select GENERIC_UDELAY
select HAVE_MONOTONIC_TIMER
select HAVE_UART_SPECIAL
diff --git a/src/soc/marvell/bg4cd/Kconfig b/src/soc/marvell/bg4cd/Kconfig
index f2cb16f..930645e 100644
--- a/src/soc/marvell/bg4cd/Kconfig
+++ b/src/soc/marvell/bg4cd/Kconfig
@@ -26,7 +26,6 @@ config SOC_MARVELL_BG4CD
select ARCH_VERSTAGE_ARMV7_M
select ARM_BOOTBLOCK_CUSTOM if VBOOT_VERIFY_FIRMWARE
select BOOTBLOCK_CONSOLE
- select EARLY_CONSOLE
select GENERIC_UDELAY
select HAVE_MONOTONIC_TIMER
select GENERIC_GPIO_LIB
diff --git a/src/soc/nvidia/tegra132/Kconfig b/src/soc/nvidia/tegra132/Kconfig
index be8ae9b..a5df92a 100644
--- a/src/soc/nvidia/tegra132/Kconfig
+++ b/src/soc/nvidia/tegra132/Kconfig
@@ -11,7 +11,6 @@ config SOC_NVIDIA_TEGRA132
select GENERIC_UDELAY
select HAVE_HARD_RESET
select HAVE_UART_SPECIAL
- select EARLY_CONSOLE
select ARM_BOOTBLOCK_CUSTOM
select SMP
select ARM64_USE_SECURE_MONITOR
More information about the coreboot-gerrit
mailing list