[coreboot-gerrit] New patch to review for coreboot: Skylake: Print GPIO MMIO base and pad config using gpio_debug token

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Mon Sep 7 18:42:40 CET 2015


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11552

-gerrit

commit 3ebac819793a420579cf4035830e7403bf6f8320
Author: Subrata Banik <subrata.banik at intel.com>
Date:   Mon Aug 31 17:10:35 2015 +0530

    Skylake: Print GPIO MMIO base and pad config using gpio_debug token
    
    This will help development activity. Default GPIO print settings is
    disable, need to set gpio_debug = 1 to get GPIO MMIO dump.
    
    BUG=None
    BRANCH=None
    TEST=build coreboot and boot on Kunimitsu.
    
    Change-Id: I70c0a7bee1593cbc8e9fe1599f45bb50e3fc0f42
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 19102612ea40184307ecb0ce8b165b5b989f6911
    Original-Change-Id: I4ea6349866c108382de9787bb9ed09fc78d9c770
    Original-Signed-off-by: Subrata Banik <subrata.banik at intel.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/296280
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/soc/intel/skylake/gpio.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/soc/intel/skylake/gpio.c b/src/soc/intel/skylake/gpio.c
index 3610a6c..64b3dda 100644
--- a/src/soc/intel/skylake/gpio.c
+++ b/src/soc/intel/skylake/gpio.c
@@ -25,6 +25,7 @@
 #include <soc/iomap.h>
 #include <soc/pm.h>
 
+static const int gpio_debug = 0;
 
 /* There are 4 communities with 8 GPIO groups (GPP_[A:G] and GPD) */
 struct gpio_community {
@@ -323,6 +324,11 @@ static void gpio_configure_pad(const struct pad_config *cfg)
 
 	if ((dw0 & PAD_FIELD(GPIROUTSMI, MASK)) == PAD_FIELD(GPIROUTSMI, YES))
 		gpi_enable_smi(cfg->pad);
+
+	if(gpio_debug)
+		printk(BIOS_DEBUG,
+			"Write Pad: Base(%p) - conf0 = %x conf1= %x pad # = %d\n",
+			&dw_regs[0], dw0, reg, cfg->pad);
 }
 
 void gpio_configure_pads(const struct pad_config *cfgs, size_t num)



More information about the coreboot-gerrit mailing list