[coreboot-gerrit] New patch to review for coreboot: sklrvp: Remove thermal.h and functions from acpi_tables.c

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/11578

-gerrit

commit 6e0036436103eea931816caa397a6fce0867348e
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Fri Sep 4 14:21:14 2015 -0700

    sklrvp: Remove thermal.h and functions from acpi_tables.c
    
    Remove thermal.h as it is not used by this board.
    Remove functions from acpi_tables.c so they can move to SOC.
    
    BUG=chrome-os-partner:40635
    BRANCH=none
    TEST=emerge-sklrvp coreboot (does not compile due to GPIO changes)
    
    Change-Id: I934fcc451a722f853034c0970074ee3259cc704f
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 7e3b5c0ed8295091d3d5761b8456f3c13c6bd8bc
    Original-Change-Id: If855f598e895e38c58657af17130158b2f73de81
    Original-Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/297757
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/mainboard/intel/sklrvp/acpi_tables.c | 43 --------------------------------
 src/mainboard/intel/sklrvp/thermal.h     | 35 --------------------------
 2 files changed, 78 deletions(-)

diff --git a/src/mainboard/intel/sklrvp/acpi_tables.c b/src/mainboard/intel/sklrvp/acpi_tables.c
index f9eb7b0..72a5888 100644
--- a/src/mainboard/intel/sklrvp/acpi_tables.c
+++ b/src/mainboard/intel/sklrvp/acpi_tables.c
@@ -17,46 +17,3 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc.
  */
-
-#include <types.h>
-#include <string.h>
-#include <cbmem.h>
-#include <console/console.h>
-#include <arch/acpi.h>
-#include <arch/ioapic.h>
-#include <arch/acpigen.h>
-#include <arch/smp/mpspec.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ids.h>
-#include <cpu/cpu.h>
-#include <soc/acpi.h>
-#include <soc/nvs.h>
-#include "thermal.h"
-
-extern const unsigned char AmlCode[];
-
-void acpi_create_gnvs(global_nvs_t *gnvs)
-{
-	acpi_init_gnvs(gnvs);
-
-	/* Disable USB ports in S5 */
-	gnvs->s5u0 = 0;
-
-	gnvs->tmps = TEMPERATURE_SENSOR_ID;
-	gnvs->tcrt = CRITICAL_TEMPERATURE;
-	gnvs->tpsv = PASSIVE_TEMPERATURE;
-	gnvs->tmax = MAX_TEMPERATURE;
-}
-
-unsigned long acpi_fill_madt(unsigned long current)
-{
-	/* Local APICs */
-	current = acpi_create_madt_lapics(current);
-
-	/* IOAPIC */
-	current += acpi_create_madt_ioapic((acpi_madt_ioapic_t *) current,
-				2, IO_APIC_ADDR, 0);
-
-	return acpi_madt_irq_overrides(current);
-}
diff --git a/src/mainboard/intel/sklrvp/thermal.h b/src/mainboard/intel/sklrvp/thermal.h
deleted file mode 100644
index 5214e7e..0000000
--- a/src/mainboard/intel/sklrvp/thermal.h
+++ /dev/null
@@ -1,35 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2013 Google Inc.
- * Copyright (C) 2015 Intel Corporation.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc.
- */
-
-#ifndef _MAINBOARD_THERMAL_H_
-#define _MAINBOARD_THERMAL_H_
-
-#define TEMPERATURE_SENSOR_ID		0	/* PECI */
-
-/* Temperature which OS will shutdown at */
-#define CRITICAL_TEMPERATURE		104
-
-/* Temperature which OS will throttle CPU */
-#define PASSIVE_TEMPERATURE		95
-
-/* Tj_max value for calculating PECI CPU temperature */
-#define MAX_TEMPERATURE			105
-
-#endif /* _MAINBOARD_THERMAL_H_ */