[coreboot-gerrit] New patch to review for coreboot: intel/skylake: Fix klockwork violation
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Thu Jan 21 09:24:13 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13072
-gerrit
commit de2d0b38cfe8a8e8d33d56fbc8d3994497fbe510
Author: Naresh G Solanki <Naresh.Solanki at intel.com>
Date: Thu Jan 14 12:22:35 2016 +0530
intel/skylake: Fix klockwork violation
File: src/soc/intel/skylake/flash_controller.c
Line: 192
Variable 'ret' might be used uninitialized in this function.
Hence initializing it with initial value of zero.
BRANCH=None
BUG=chrome-os-partner:48542
TEST=Built & booted Kunimitsu board.
Change-Id: I4e63612890057a2180f38b2e74419d98b02b70c1
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Original-Commit-Id: b93ca876912d2336dae25b9b84e56ffb171b215b
Original-Change-Id: Ied8c909f5294d56daddb2806111d477246f98957
Original-Reviewed-on: https://chromium-review.googlesource.com/322082
Original-Commit-Ready: Naresh Solanki <naresh.solanki at intel.com>
Original-Tested-by: Naresh Solanki <naresh.solanki at intel.com>
Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
src/soc/intel/skylake/flash_controller.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/intel/skylake/flash_controller.c b/src/soc/intel/skylake/flash_controller.c
index 25562a5..0af0484 100644
--- a/src/soc/intel/skylake/flash_controller.c
+++ b/src/soc/intel/skylake/flash_controller.c
@@ -182,7 +182,7 @@ void spi_release_bus(struct spi_slave *slave)
int pch_hwseq_erase(struct spi_flash *flash, u32 offset, size_t len)
{
u32 start, end, erase_size;
- int ret;
+ int ret = 0;
erase_size = flash->sector_size;
if (offset % erase_size || len % erase_size) {
More information about the coreboot-gerrit
mailing list