[coreboot-gerrit] Patch set updated for coreboot: arch/x86/Makefile.inc: Re-enable -Wa, --divide assembler flag
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Sat Jan 30 06:19:07 CET 2016
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13299
-gerrit
commit c1c4a60489df9780a376b25b66e40075afa4f281
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Tue Oct 6 14:41:20 2015 -0700
arch/x86/Makefile.inc: Re-enable -Wa,--divide assembler flag
In the follow-on patches, we use constant division to calculate the
number of elements in an assembly structure. Since the size of one
element is not a power of two for all structures, we can't bit shift.
This allows us to do the computation at assembly time rather than
runtime.
Change-Id: Ic5693f39dee8daf759bfc16c79ac3c7ddb4de465
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/arch/x86/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 21084d3..d96f6e7 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -84,7 +84,7 @@ define early_x86_stage
$(1)-y += memlayout.ld
# The '.' include path is needed for the generated assembly.inc file.
-$(1)-S-ccopts += -I.
+$(1)-S-ccopts += -I. -Wa,--divide
$$(objcbfs)/$(1).debug: $$$$($(1)-libs) $$$$($(1)-objs)
@printf " LINK $$(subst $$(obj)/,,$$(@))\n"
More information about the coreboot-gerrit
mailing list