[coreboot-gerrit] New patch to review for coreboot: soc/apollolake: Put CSE to low power state

Hannah Williams (hannah.williams@intel.com) gerrit at coreboot.org
Thu Jun 2 23:38:29 CEST 2016


Hannah Williams (hannah.williams at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15054

-gerrit

commit a1dec0d0cddc85a97af91fb1638bdb452fabe8f1
Author: Hannah Williams <hannah.williams at intel.com>
Date:   Fri Apr 29 14:48:20 2016 -0700

    soc/apollolake: Put CSE to low power state
    
    fsp_notify(END_OF_FIRMWARE) should be sent to FSP to enable putting CSE
    in low power state
    
    Change-Id: I76b8e85ccf077032616ba8e4a333d9264dc65ed2
    Signed-off-by: Hannah Williams <hannah.williams at intel.com>
---
 src/soc/intel/apollolake/chip.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/soc/intel/apollolake/chip.c b/src/soc/intel/apollolake/chip.c
index f56e1f2..4fb1084 100644
--- a/src/soc/intel/apollolake/chip.c
+++ b/src/soc/intel/apollolake/chip.c
@@ -136,6 +136,10 @@ static void fsp_notify_dummy(void *arg)
 
 	if (fsp_notify(ph) != FSP_SUCCESS)
 		printk(BIOS_CRIT, "FspNotify failed!\n");
+	/* Call END_OF_FIRMWARE Notify after READY_TO_BOOT Notify */
+	if (ph == READY_TO_BOOT)
+		if (fsp_notify(END_OF_FIRMWARE) != FSP_SUCCESS)
+			printk(BIOS_CRIT, "FspNotify-END_OF_FIRMWARE failed!\n");
 }
 
 BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, fsp_notify_dummy,



More information about the coreboot-gerrit mailing list