[coreboot-gerrit] New patch to review for coreboot: amd/geode: Fix comment about ACPI S3

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Jun 17 22:56:36 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15237

-gerrit

commit 4aa2046fde984fe3c88b5b74bc32f57bfce719b1
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu Jun 16 19:50:36 2016 +0300

    amd/geode: Fix comment about ACPI S3
    
    As RAMTOP gets removed, comment becomes inaccurate.
    
    Change-Id: Iaf25b88a4065d15c0c0682425b1d033e4a36590f
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/geode_gx2/cache_as_ram.inc | 4 +---
 src/cpu/amd/geode_lx/cache_as_ram.inc  | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/cpu/amd/geode_gx2/cache_as_ram.inc b/src/cpu/amd/geode_gx2/cache_as_ram.inc
index e0beba0..bd9de28 100644
--- a/src/cpu/amd/geode_gx2/cache_as_ram.inc
+++ b/src/cpu/amd/geode_gx2/cache_as_ram.inc
@@ -181,9 +181,7 @@ done_cache_as_ram_main:
 __main:
 	post_code(POST_PREPARE_RAMSTAGE)
 
-	/* TODO For suspend/resume the cache will have to live between
-	 * CONFIG_RAMBASE and CONFIG_RAMTOP
-	 */
+	/* TODO For suspend/resume low memory needs backup store. */
 
 	cld				/* clear direction flag */
 
diff --git a/src/cpu/amd/geode_lx/cache_as_ram.inc b/src/cpu/amd/geode_lx/cache_as_ram.inc
index 9b34a63..cbc5cb8 100644
--- a/src/cpu/amd/geode_lx/cache_as_ram.inc
+++ b/src/cpu/amd/geode_lx/cache_as_ram.inc
@@ -208,9 +208,7 @@ done_cache_as_ram_main:
 __main:
 	post_code(POST_PREPARE_RAMSTAGE)
 
-	/* TODO For suspend/resume the cache will have to live between
-	 * CONFIG_RAMBASE and CONFIG_RAMTOP
-	 */
+	/* TODO For suspend/resume low memory needs backup store. */
 
 	cld				/* clear direction flag */
 



More information about the coreboot-gerrit mailing list