[coreboot-gerrit] New patch to review for coreboot: samsung/lumpy: Fix build with System Agent blob

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jun 23 16:23:53 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15329

-gerrit

commit 070fe2b4159cd24afcc415be3669034495b47a98
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu Jun 23 14:00:51 2016 +0300

    samsung/lumpy: Fix build with System Agent blob
    
    Broken with commit:
      9cbe93a mb/samsung/lumpy/romstage: read SPD data of removable DIMM
    
    The blob can pick SPDs from the addresses defined in pei_data
    and we do only define read_spd() with USE_NATIVE_RAMINIT.
    
    Change-Id: Ibd6d7a4a53fa808b476d3060872cb10d3dfce534
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/samsung/lumpy/romstage.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/mainboard/samsung/lumpy/romstage.c b/src/mainboard/samsung/lumpy/romstage.c
index 4d318b7..918c73a 100644
--- a/src/mainboard/samsung/lumpy/romstage.c
+++ b/src/mainboard/samsung/lumpy/romstage.c
@@ -216,8 +216,6 @@ void mainboard_fill_pei_data(struct pei_data *pei_data)
 	*pei_data = pei_data_template;
 	// leave onboard dimm address at f0, and copy spd data there.
 	memcpy(pei_data->spd_data[0], locate_spd(), 256);
-	/* read removable dimm spd */
-	read_spd(&pei_data->spd_data[2], 0x50);
 }
 
 const struct southbridge_usb_port mainboard_usb_ports[] = {



More information about the coreboot-gerrit mailing list