[coreboot-gerrit] New patch to review for coreboot: sandybridge dual asymmetric RAM [NOTFORMERGE]

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Thu Jun 23 16:23:58 CEST 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15330

-gerrit

commit 14ae3640e7e0b4ece1bbcbea0f495c4c31c1ba17
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Thu Jun 23 15:32:51 2016 +0300

    sandybridge dual asymmetric RAM [NOTFORMERGE]
    
    hack samsung/lumpy with combination of 2Gib on-board, 4GiB SO-DIMM
    
    Change-Id: I3a8108b3bdc5a4c925a2e615aa3971cb267cd799
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/northbridge/intel/sandybridge/raminit.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/northbridge/intel/sandybridge/raminit.c b/src/northbridge/intel/sandybridge/raminit.c
index cf66a0d..8736c71 100644
--- a/src/northbridge/intel/sandybridge/raminit.c
+++ b/src/northbridge/intel/sandybridge/raminit.c
@@ -1043,10 +1043,15 @@ static void dram_dimm_mapping(ramctr_timing *ctrl)
 
 static void dram_dimm_set_mapping(ramctr_timing * ctrl)
 {
+#if 0
 	int channel;
 	FOR_ALL_CHANNELS {
 		MCHBAR32(0x5004 + channel * 4) = ctrl->mad_dimm[channel];
 	}
+#else
+	MCHBAR32(0x5004) = ctrl->mad_dimm[1];
+	MCHBAR32(0x5008) = ctrl->mad_dimm[0];
+#endif
 }
 
 static void dram_zones(ramctr_timing * ctrl, int training)
@@ -1063,7 +1068,7 @@ static void dram_zones(ramctr_timing * ctrl, int training)
 		ch1size = ctrl->channel_size_mb[1];
 	}
 
-	if (ch0size >= ch1size) {
+	if (ch1size >= ch0size) {
 		reg = MCHBAR32(0x5014);
 		val = ch1size / 256;
 		reg = (reg & ~0xff000000) | val << 24;



More information about the coreboot-gerrit mailing list