[coreboot-gerrit] New patch to review for coreboot: google/oak: Config PANEL_LCD_POWER_EN for rev5

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Mar 8 22:35:18 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13971

-gerrit

commit 1f5a601d00c3fd9997467c454155949cf4a0d608
Author: Yidi Lin <yidi.lin at mediatek.com>
Date:   Mon Dec 28 16:40:54 2015 +0800

    google/oak: Config PANEL_LCD_POWER_EN for rev5
    
    BRANCH=none
    BUG=none
    TEST=emerge-oak coreboot
    
    Change-Id: Ic2019a1d61cbc5949c1f42346b279ef05f725dfb
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: bf13606f01438bc2ea27ecccc6359a7320dc34cc
    Original-Change-Id: I3fcc403cb7a3429b9673be0e727fc7d8c9d4f556
    Original-Signed-off-by: Yidi Lin <yidi.lin at mediatek.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/320027
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/mainboard/google/oak/mainboard.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/mainboard/google/oak/mainboard.c b/src/mainboard/google/oak/mainboard.c
index 1713c9b..c330fac 100644
--- a/src/mainboard/google/oak/mainboard.c
+++ b/src/mainboard/google/oak/mainboard.c
@@ -144,28 +144,24 @@ static void configure_usb(void)
 /* Setup backlight control pins as output pin and power-off by default */
 static void configure_backlight(void)
 {
+	/* Configure PANEL_LCD_POWER_EN */
 	switch (board_id()) {
-	case 0:
-		gpio_output(PAD_DISP_PWM0, 0); /* DISP_PWM0 */
-		mt6391_gpio_output(MT6391_KP_ROW3, 0); /* PANEL_POWER_EN_6397 */
-		break;
 	case 1:
 	case 2:
-		gpio_output(PAD_DISP_PWM0, 0); /* DISP_PWM0 */
-		gpio_output(PAD_PCM_TX, 0); /* PANEL_POWER_EN */
 		break;
 	case 3:
-		gpio_output(PAD_UCTS2, 0); /* PANEL_LCD_POWER_EN */
-		gpio_output(PAD_DISP_PWM0, 0); /* DISP_PWM0 */
-		gpio_output(PAD_PCM_TX, 0); /* PANEL_POWER_EN */
+		gpio_output(PAD_UCTS2, 0);
 		break;
 	case 4:
+		gpio_output(PAD_SRCLKENAI, 0);
+		break;
 	default:
-		gpio_output(PAD_SRCLKENAI, 0); /* PANEL_LCD_POWER_EN */
-		gpio_output(PAD_DISP_PWM0, 0); /* DISP_PWM0 */
-		gpio_output(PAD_PCM_TX, 0); /* PANEL_POWER_EN */
+		gpio_output(PAD_UTXD2, 0);
 		break;
 	}
+
+	gpio_output(PAD_DISP_PWM0, 0);	/* DISP_PWM0 */
+	gpio_output(PAD_PCM_TX, 0);	/* PANEL_POWER_EN */
 }
 
 static void mainboard_init(device_t dev)



More information about the coreboot-gerrit mailing list