[coreboot-gerrit] Patch set updated for coreboot: src/arch/x86/acpi.c: Use correct host address width in DMAR ACPI table

Jacob Laska (jlaska91@gmail.com) gerrit at coreboot.org
Fri Mar 18 17:37:42 CET 2016


Jacob Laska (jlaska91 at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/14102

-gerrit

commit 79ef17971a8a441b8d0bed8421e15df3b36c4b95
Author: Jacob Laska <jlaska at xes-inc.com>
Date:   Tue Mar 15 21:53:27 2016 -0500

    src/arch/x86/acpi.c: Use correct host address width in DMAR ACPI table
    
    The previous implementation assumed the CPU physical address size to
    be 40 which is not true of all platforms. Use an existing function to
    obtain the correct CPU physical address to report in the DMAR ACPI
    table.
    
    Change-Id: Ia79e9dadecc3f5f6a86ce3789b213222bef482b3
    Signed-off-by: Jacob Laska <jlaska91 at gmail.com>
---
 src/arch/x86/acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c
index a21bae2..5640ad0 100644
--- a/src/arch/x86/acpi.c
+++ b/src/arch/x86/acpi.c
@@ -411,7 +411,7 @@ void acpi_create_dmar(acpi_dmar_t *dmar, enum dmar_flags flags,
 	header->length = sizeof(acpi_dmar_t);
 	header->revision = 1;
 
-	dmar->host_address_width = 40 - 1; /* FIXME: == MTRR size? */
+	dmar->host_address_width = cpu_phys_address_size() - 1;
 	dmar->flags = flags;
 
 	current = acpi_fill_dmar(current);



More information about the coreboot-gerrit mailing list