[coreboot-gerrit] New patch to review for coreboot: riscv: Use the generic src/lib/bootblock.c
Jonathan Neuschäfer (j.neuschaefer@gmx.net)
gerrit at coreboot.org
Wed Oct 12 11:34:13 CEST 2016
Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16995
-gerrit
commit a9249cb8d7dc42dfd983efe89f3e13fa75f134ee
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date: Wed Oct 12 00:18:01 2016 +0200
riscv: Use the generic src/lib/bootblock.c
TEST=Compiled for and ran on spike; it booted as before.
Change-Id: Id173643a3571962406f9191db248b206235dca35
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
src/arch/riscv/Kconfig | 1 -
src/mainboard/emulation/qemu-riscv/Makefile.inc | 1 -
src/mainboard/emulation/qemu-riscv/bootblock.c | 31 ------------------------
src/mainboard/emulation/spike-riscv/Makefile.inc | 1 -
src/mainboard/emulation/spike-riscv/bootblock.c | 30 -----------------------
5 files changed, 64 deletions(-)
diff --git a/src/arch/riscv/Kconfig b/src/arch/riscv/Kconfig
index 9a35cf2..a30cb70 100644
--- a/src/arch/riscv/Kconfig
+++ b/src/arch/riscv/Kconfig
@@ -6,7 +6,6 @@ config ARCH_BOOTBLOCK_RISCV
bool
default n
select ARCH_RISCV
- select BOOTBLOCK_CUSTOM
select C_ENVIRONMENT_BOOTBLOCK
config ARCH_VERSTAGE_RISCV
diff --git a/src/mainboard/emulation/qemu-riscv/Makefile.inc b/src/mainboard/emulation/qemu-riscv/Makefile.inc
index b8a62f7..4fbe401 100644
--- a/src/mainboard/emulation/qemu-riscv/Makefile.inc
+++ b/src/mainboard/emulation/qemu-riscv/Makefile.inc
@@ -12,7 +12,6 @@
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
-bootblock-y += bootblock.c
bootblock-y += uart.c
bootblock-y += qemu_util.c
bootblock-y += rom_media.c
diff --git a/src/mainboard/emulation/qemu-riscv/bootblock.c b/src/mainboard/emulation/qemu-riscv/bootblock.c
deleted file mode 100644
index 3e88620..0000000
--- a/src/mainboard/emulation/qemu-riscv/bootblock.c
+++ /dev/null
@@ -1,31 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2013 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <arch/exception.h>
-#include <bootblock_common.h>
-#include <console/console.h>
-#include <program_loading.h>
-
-// the qemu part of all this is very, very non-hardware like.
-// so it gets its own bootblock.
-void main(void)
-{
- if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) {
- console_init();
- exception_init();
- }
-
- run_romstage();
-}
diff --git a/src/mainboard/emulation/spike-riscv/Makefile.inc b/src/mainboard/emulation/spike-riscv/Makefile.inc
index 91c1369..e3c9481 100644
--- a/src/mainboard/emulation/spike-riscv/Makefile.inc
+++ b/src/mainboard/emulation/spike-riscv/Makefile.inc
@@ -12,7 +12,6 @@
## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
## GNU General Public License for more details.
-bootblock-y += bootblock.c
bootblock-y += uart.c
bootblock-y += spike_util.c
bootblock-y += rom_media.c
diff --git a/src/mainboard/emulation/spike-riscv/bootblock.c b/src/mainboard/emulation/spike-riscv/bootblock.c
deleted file mode 100644
index 40a7de1..0000000
--- a/src/mainboard/emulation/spike-riscv/bootblock.c
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2013 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- * GNU General Public License for more details.
- */
-
-#include <arch/exception.h>
-#include <bootblock_common.h>
-#include <console/console.h>
-#include <program_loading.h>
-
-// the qemu part of all this is very, very non-hardware like.
-// so it gets its own bootblock.
-void main(void)
-{
- if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) {
- console_init();
- exception_init();
- }
- run_romstage();
-}
More information about the coreboot-gerrit
mailing list