[coreboot-gerrit] New patch to review for coreboot: intel/{skylake, apollolake}: Enable signalling of error condition

[Patrick Georgi (pgeorgi@google.com)]

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17054

-gerrit

commit d822f5ab8a89e6748597d503e8fcf4b028645975
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Fri Jul 29 18:37:56 2016 +0200

    intel/{skylake,apollolake}: Enable signalling of error condition
    
    Testing for "devfn < 0" on an unsigned doesn't work, and i2c_bus_to_devfn
    returns an int (with -1 for "error"), so use int for devfn.
    
    Adapt Change-Id I7d1cdb6af4140f7dc322141c0c018d8418627434 to fix more
    instances.
    
    Change-Id: I001a9b484a68e018798a65c0fae11f8df7d9f564
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1357450, #1357449
---
 src/soc/intel/apollolake/i2c_early.c | 2 +-
 src/soc/intel/skylake/i2c.c          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/soc/intel/apollolake/i2c_early.c b/src/soc/intel/apollolake/i2c_early.c
index 968e993..82883f8 100644
--- a/src/soc/intel/apollolake/i2c_early.c
+++ b/src/soc/intel/apollolake/i2c_early.c
@@ -32,7 +32,7 @@ static int i2c_early_init_bus(unsigned bus)
 	const struct lpss_i2c_speed_config *sptr;
 	enum i2c_speed speed;
 	pci_devfn_t dev;
-	unsigned devfn;
+	int devfn;
 	uintptr_t base;
 	uint32_t value;
 	void *reg;
diff --git a/src/soc/intel/skylake/i2c.c b/src/soc/intel/skylake/i2c.c
index eebe665..d37c290 100644
--- a/src/soc/intel/skylake/i2c.c
+++ b/src/soc/intel/skylake/i2c.c
@@ -24,7 +24,7 @@
 
 uintptr_t lpss_i2c_base_address(unsigned bus)
 {
-	unsigned devfn;
+	int devfn;
 	struct device *dev;
 	struct resource *res;