[coreboot-gerrit] New patch to review for coreboot: intel/broadwell: "free" memory after use
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Tue Oct 18 19:47:56 CEST 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17055
-gerrit
commit d495199b2b828ac7784c8322c5671ca87a14e1a1
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Tue Oct 18 19:46:33 2016 +0200
intel/broadwell: "free" memory after use
While we stub out free(), tools like coverity scan have no idea, and it
might change in the future. So free it.
Change-Id: I1d93a6f45b64445662daa95b51128140ad0a87e2
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1260716
---
src/soc/intel/broadwell/me.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/soc/intel/broadwell/me.c b/src/soc/intel/broadwell/me.c
index 893c19b..1b086ec 100644
--- a/src/soc/intel/broadwell/me.c
+++ b/src/soc/intel/broadwell/me.c
@@ -966,6 +966,7 @@ static int intel_me_read_mbp(me_bios_payload *mbp_data, device_t dev)
}
#undef ASSIGN_FIELD_PTR
+ free(mbp);
return ret;
}
More information about the coreboot-gerrit
mailing list