[coreboot] [flashrom][PATCH] typo in Makefile

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Sun Apr 26 00:08:26 CEST 2009


On 24.04.2009 15:09, stephan.guilloux at free.fr wrote:
> Selon Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>:
>   
>> On 24.04.2009 14:16, Ward Vandewege wrote:
>>     
>>> On Fri, Apr 24, 2009 at 11:15:07AM +0200, stephan.guilloux at free.fr wrote:
>>>
>>>       
>>>>>> Found some typo in Makefile which was producing some "strange
>>>>>>             
>> behaviours"
>>     
>> I originally insisted on >& because it worked on tcsh, but since make
>> uses /bin/sh and /bin/sh has to be POSIX compliant, we can use the POSIX
>> variant. >& is not POSIX compliant, but
>>  >/dev/null 2>&1
>> is POSIX compliant. This is specified in SuSv3, Shell command language,
>> sections 2.7.2 and 2.7.6.
>>
>>     
>>>>>> Signed-off-by: Stephan Guilloux <stephan.guilloux at free.fr>
>>>>>>
>>>>>>             
>>> Acked-by: Ward Vandewege <ward at gnu.org>
>>>
>>>       
>> Stephan, would you mind resubmitting the 2>&1 variant? Thanks.
>>     
> Here it is and in attachment.
>
> Stephan.
>
> Signed-off-by: Stephan Guilloux <stephan.guilloux at free.fr>
>   

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>

Thanks, committed in r4211.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the coreboot mailing list