[flashrom] [PATCH] fix MSR code in flashrom
Carl-Daniel Hailfinger
c-d.hailfinger.devel.2006 at gmx.net
Tue Aug 11 15:43:46 CEST 2009
On 11.08.2009 15:00, Stefan Reinauer wrote:
> See patch... With this flashrom won't try to open /dev/cpu/x/msr on
> non-linux OSes...
>
> Fix up MSR handling in flashrom to support more OSes than Linux.
>
> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
>
I'm not totally happy with the abstraction and think getting MSR access
should be part of getting IO permissions, but this is a good step forward.
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
It would be nice if you could address the one comment below, either with
an updated patch or a second fixup patch.
Regards,
Carl-Daniel
> Index: chipset_enable.c
> ===================================================================
> --- chipset_enable.c (revision 676)
> +++ chipset_enable.c (working copy)
> @@ -527,92 +527,35 @@
> static int enable_flash_cs5536(struct pci_dev *dev, const char *name)
> {
> #define MSR_RCONF_DEFAULT 0x1808
> #define MSR_NORF_CTL 0x51400018
>
> - int fd_msr;
> - unsigned char buf[8];
> + msr_t msr;
>
> - fd_msr = open("/dev/cpu/0/msr", O_RDWR);
> - if (fd_msr == -1) {
> - perror("open(/dev/cpu/0/msr)");
> - printf("Cannot operate on MSR. Did you run 'modprobe msr'?\n");
> - return -1;
> - }
> + /* Geode only has a single core */
> + setup_cpu_msr(0);
>
Missing error handling for the setup case. rdmsr and wrmsr don't have to
be checked after setup was successful.
--
http://www.hailfinger.org/
More information about the flashrom
mailing list